Skip to content

Conversation

EdwinVW
Copy link
Contributor

@EdwinVW EdwinVW commented Jan 3, 2021

Chapter 8 of the Dapr for .NET devs ebook about bindings.

amolenk and others added 4 commits September 7, 2020 08:37
* Add chapter file containing emtpy template

* Initial draft

* Grammer updates

* Add eShopOnDapr sample

* Update reference

* Update port number

* Update eShop example

* Update grammar in eShop section

* Revise 'how it works' sample

* Remove obsolete line

* Add input vs. output paragraph

* Add Cron binding paragraph

* Add summary

* Add .NET SDK section

* Update figure captions and previous / next links

* Chapter 8: Resource Bindings - Robert's review (#17)

* Initial push

* WIP

* WIP - First pass

* First candidate for review completion

* Ready for team review

* Acrolynx corrections - ready for review

Co-authored-by: Rob Vettor <[email protected]>
Co-authored-by: Edwin van Wijk <[email protected]>

* Change config in conceptual arch diagram

* Fix markdown lint errors

* Remove outline in conceptual arch diagram

* Minor changes after review

* Apply suggestions from code review

Co-authored-by: Sander Molenkamp <[email protected]>

* Process review suggestions

* Fix formatting

* Fix code snippet

* Apply review suggestion

* Apply review suggestion

* Update "how it works" paragraph

* Update code samples

* Apply review suggestion

Co-authored-by: Sander Molenkamp <[email protected]>
Co-authored-by: Rob Vettor <[email protected]>
@amolenk
Copy link
Contributor

amolenk commented Jan 30, 2021

This is chapter 8 about the Bindings building block.

@nishanil / @IEvangelist please review. Thanks!

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are several compile errors with the C# snippets include, and a few other minor nits.

@EdwinVW
Copy link
Contributor Author

EdwinVW commented Feb 1, 2021

There are several compile errors with the C# snippets include, and a few other minor nits.

@IEvangelist I'll review your suggestions a.s.a.p.
Thanks!

@EdwinVW
Copy link
Contributor Author

EdwinVW commented Feb 2, 2021

@IEvangelist I've applied your suggestions. Please review.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

@IEvangelist IEvangelist merged commit f3a21a2 into dotnet:ebook-dapr-for-net-devs Feb 2, 2021
@robvet robvet deleted the dapr/release/bb-bindings branch May 1, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants